根据代码量/质量分析,修改可能含有坏味道的代码

master
OPGame 7 years ago
parent 53edcaffa2
commit 3c4511d24e

@ -14,6 +14,7 @@ import cn.hutool.core.util.StrUtil;
import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper; import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
import com.baomidou.mybatisplus.core.metadata.IPage; import com.baomidou.mybatisplus.core.metadata.IPage;
import com.yami.shop.bean.model.Brand; import com.yami.shop.bean.model.Brand;
import com.yami.shop.common.exception.YamiShopBindException;
import com.yami.shop.common.util.PageParam; import com.yami.shop.common.util.PageParam;
import com.yami.shop.service.BrandService; import com.yami.shop.service.BrandService;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
@ -65,10 +66,10 @@ public class BrandController {
*/ */
@PostMapping @PostMapping
@PreAuthorize("@pms.hasPermission('admin:brand:save')") @PreAuthorize("@pms.hasPermission('admin:brand:save')")
public ResponseEntity<?> save(@Valid Brand brand) { public ResponseEntity<Void> save(@Valid Brand brand) {
Brand dbBrand = brandService.getByBrandName(brand.getBrandName()); Brand dbBrand = brandService.getByBrandName(brand.getBrandName());
if (dbBrand != null) { if (dbBrand != null) {
return ResponseEntity.badRequest().body("该品牌名称已存在"); throw new YamiShopBindException("该品牌名称已存在");
} }
brandService.save(brand); brandService.save(brand);
return ResponseEntity.ok().build(); return ResponseEntity.ok().build();
@ -79,10 +80,10 @@ public class BrandController {
*/ */
@PutMapping @PutMapping
@PreAuthorize("@pms.hasPermission('admin:brand:update')") @PreAuthorize("@pms.hasPermission('admin:brand:update')")
public ResponseEntity<?> update(@Valid Brand brand) { public ResponseEntity<Void> update(@Valid Brand brand) {
Brand dbBrand = brandService.getByBrandName(brand.getBrandName()); Brand dbBrand = brandService.getByBrandName(brand.getBrandName());
if (dbBrand != null && !Objects.equals(dbBrand.getBrandId(), brand.getBrandId())) { if (dbBrand != null && !Objects.equals(dbBrand.getBrandId(), brand.getBrandId())) {
return ResponseEntity.badRequest().body("该品牌名称已存在"); throw new YamiShopBindException("该品牌名称已存在");
} }
brandService.updateById(brand); brandService.updateById(brand);
return ResponseEntity.ok().build(); return ResponseEntity.ok().build();

Loading…
Cancel
Save